jinxing64 commented on a change in pull request #16118:
URL: https://github.com/apache/flink/pull/16118#discussion_r670320025
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTrackerImpl.java
##########
@@ -78,6 +77,22 @@ public void startTrackingPartition(
producingTaskExecutorId, resultPartitionId,
resultPartitionDeploymentDescriptor);
}
+ @Override
+ public Collection<PartitionTrackerEntry<ResourceID,
ResultPartitionDeploymentDescriptor>>
+ stopTrackingPartitionsFor(ResourceID producingTaskExecutorId) {
+ Preconditions.checkNotNull(producingTaskExecutorId);
+
+ // stop tracking partitions which are accommodated on TM
+ Set<ResultPartitionID> rIds =
+
partitionTable.getTrackedPartitions(producingTaskExecutorId).stream()
+ .map(rId -> partitionInfos.get(rId).getMetaInfo())
+
.filter(JobMasterPartitionTrackerImpl::isPartitionWithLocalResources)
+ .map(desc ->
desc.getShuffleDescriptor().getResultPartitionID())
+ .collect(Collectors.toSet());
+ partitionTable.stopTrackingPartitions(producingTaskExecutorId);
Review comment:
Sure I will remove this invocation ~
But I'm hesitate to think there's issue in
`AbstractPartitionTracker#stopTrackingPartitionsFor` -- the idea is to stop
tracking by tmID and get corresponding partitionID, then stop tracking by
partitionID. Is there redundancy ? Did I get it wrong ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
