rkhachatryan commented on a change in pull request #16510:
URL: https://github.com/apache/flink/pull/16510#discussion_r670871109
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/JobManagerTaskRestore.java
##########
@@ -58,4 +78,12 @@ public String toString() {
+ taskStateSnapshot
+ '}';
}
+
+ public Set<StateObjectID> getSharedStateObjectIDs() {
+ return unmodifiableSet(sharedStateObjectIDs);
+ }
+
+ void addSharedObjectStateID(StateObjectID sharedStateID) {
+ sharedStateObjectIDs.add(sharedStateID);
Review comment:
This set is mutable, because it's only possible to compute shared state
once it is assigned.
It probably can be avoided by doing an additional pass in
`StateAssignementOperation` with some "fake" graph objects or collecting the
assingments, but this doesn't seem to worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
