pnowojski commented on a change in pull request #22:
URL: https://github.com/apache/flink-benchmarks/pull/22#discussion_r670976806
##########
File path:
src/main/java/org/apache/flink/benchmark/UnalignedCheckpointTimeBenchmark.java
##########
@@ -116,6 +116,7 @@ protected int getNumberOfSlotsPerTaskManager() {
@Override
protected int getNumberOfTaskManagers() {
+ // why is this using PARALLELISM when we don't actually use it?
Review comment:
this is probably a bug, `PARALLELISM` should have been used instead of
`parallelism` in `env.setParallelism(parallelism);`. But let's keep it for now
for continuity of the benchmark results while we are merging this? I can fix it
later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
