Airblader commented on a change in pull request #16516:
URL: https://github.com/apache/flink/pull/16516#discussion_r671391007
##########
File path: flink-python/pyflink/table/catalog.py
##########
@@ -733,9 +734,22 @@ def get_schema(self) -> TableSchema:
Get the schema of the table.
:return: Schema of the table/view.
+
+ . note:: Deprecated in 1.14. This method returns the deprecated
ableSchema class. The old
Review comment:
nit: missing "T" in TableSchema"
##########
File path: flink-python/pyflink/common/config_options.py
##########
@@ -0,0 +1,125 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+from typing import TypeVar, Generic
+
+from pyflink.java_gateway import get_gateway
+
+T = TypeVar('T')
+
+__all__ = ['ConfigOptions', 'ConfigOption']
+
+
+class ConfigOptions(object):
+ """
+ {@code ConfigOptions} are used to build a
:class:`~pyflink.table.ConfigOption`. The option is
+ typically built in one of the following pattern:
Review comment:
nit: "pattern" → "patterns"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
