predatorray commented on pull request #16494: URL: https://github.com/apache/flink/pull/16494#issuecomment-881873136
Hi, @pnowojski. Thanks for your review again! According to the comments in the previous review, I pushed a new commit. Here are the major changes: - Mockito has been removed from the ITCase. Instead, I introduced a new method `getTransactionalId()` in the `FlinkKafkaProducer`, which is only `VisibleForTesting`. - `@Nullable` annotation was added on the `transactionalIdPrefix` field. - `Preconditions.checkNotNull` was done in the `setTransactionalId` method. The javadoc has also been updated. - additional unit/integration tests added, where the default transactional.id generation behavior (taskName + operatorID) and throwing NPE when providing a null transactionalIdPrefix were also tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
