curcur edited a comment on pull request #16315: URL: https://github.com/apache/flink/pull/16315#issuecomment-881322557
After reading the PR, I think it aims for two sets of log enhancements. Please correct me if I misunderstand: 1. Add stack trace of thread dump in some places. Would you mind sharing a bit of what extra info is exposed with these stack traces? The calling stack seems to be able to be tracked through function calls; Also, I think the most important info should already be included in the `throwable error` stack trace". The `throwable error` stack will be printed when the error is handled. If it is not, we probably should understand why and fix it there. 2. log remote channel address in `notifyAllChannelsOfErrorAndClose` (I do not think other added logging in this method provides any more msg, reason same as point 1) To my best knowledge, if an error is due to a remote error (sender side or network), it will be wrapped as a `RemoteTransportException` which has already included remote socket address; otherwise, the error can be any type of Throwable, which I think should be enough in most cases. But if you really think we should log remote socket address in all cases, we can wrap to a unified type of Exceptions (like ChannelException, and including the remote address and local address in it). That's the simplest way I can think of without violating and polluting existing logs. Please let me know what do you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
