twalthr opened a new pull request #16536:
URL: https://github.com/apache/flink/pull/16536


   ## What is the purpose of the change
   
   This refactors some enum classes that are used for more or less the same 
purpose but in different parts of the stack with different values. It should 
reduce confusion and collisions with API classes.
   
   The new naming is as follows:
   
   ```
   DataExchangeMode (for network stack, remains as it is)
   
   ShuffleMode -> StreamExchangeMode (belongs to *stream* graph and influences 
the data *exchange*)
   
   GlobalDataExchangeMode -> GlobalStreamExchangeMode (belongs to *stream* 
graph and influences the data *exchange* but globally)
   ```
   
   In docs and API we expose the word "shuffle" also for shuffle service etc., 
thus, we will add a new `ShuffleMode` enum according to FLIP-134. The enum 
class will follow in the next PR. The word "exchange" is used internally for 
declaring shuffles in graphs.
   
   ## Brief change log
   
   Use the term "exchange mode" consistently.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: yes
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to