edu05 commented on pull request #16487: URL: https://github.com/apache/flink/pull/16487#issuecomment-883469221
@dmvk The idea was not to remove the test just because it failed, I should have left an explanation for its removal, apologies! The CheckpointStoreITCase effectively tested 1. Restore happens within CheckpointStore 2. If restore fails job is restarted I thought the intention was to never recover() inside CheckpointStore and to fail entirely if the new invocation failed, for that reason I removed the test. I was left in doubt about the need for a new acceptance test, your suggestion of a DefaultCompletedCheckpointStore with blocking state handles is exactly that! I'll implement all your suggestions and ping you back :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
