godfreyhe commented on a change in pull request #16503:
URL: https://github.com/apache/flink/pull/16503#discussion_r675378901
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/rules/logical/CorrelateSortToRankRuleTest.scala
##########
@@ -95,34 +94,35 @@ class CorrelateSortToRankRuleTest extends TableTestBase {
}
@Test
- def testAggCallNotSupported(): Unit = {
+ def testNonInnerJoinNotSupported(): Unit = {
Review comment:
please add some tests about equal with constant value, such as `WHERE
f0 = t2.f0 AND f1 = 1` or `WHERE f0 = t2.f0 AND 1 = t2.f1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
