zhuzhurk commented on a change in pull request #16498:
URL: https://github.com/apache/flink/pull/16498#discussion_r677928575
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/PermanentBlobService.java
##########
@@ -50,13 +50,20 @@
/**
* Returns the content of the file for the BLOB with the provided job ID
the blob key.
*
+ * <p>Compared to {@code getFile}, {@code readFile} will attempt to read
the entire file after
+ * retrieving it. If file reading and file retrieving is done in the same
WRITE lock, it can
+ * avoid the scenario that the path to the file is deleted concurrently by
other threads at the
+ * same time as the file is retrieved and read.
Review comment:
maybe "at the same time as the file is retrieved and read" -> "when the
file is retrieved but not read yet"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
