twalthr commented on a change in pull request #16638:
URL: https://github.com/apache/flink/pull/16638#discussion_r680828464
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java
##########
@@ -155,4 +150,12 @@ public void testGetNoSchemaGenericTable() throws Exception
{
CatalogBaseTable catalogTable = hiveCatalog.getTable(hiveObjectPath);
assertEquals(TableSchema.builder().build(), catalogTable.getSchema());
}
+
+ private static Map<String, String> getFileSystemConnectorOptions(String
path) {
Review comment:
nit: add `Legacy` to the method name so that readers don't copy it
##########
File path: docs/content.zh/docs/dev/table/catalogs.md
##########
@@ -169,24 +168,15 @@ tableEnv.registerCatalog("myhive", catalog);
catalog.createDatabase("mydb", new CatalogDatabaseImpl(...));
// Create a catalog table
-TableSchema schema = TableSchema.builder()
- .field("name", DataTypes.STRING())
- .field("age", DataTypes.INT())
+final Schema schema = Schema.newBuilder()
+ .column("name", DataTypes.STRING())
+ .column("age", DataTypes.STRING())
Review comment:
nit: `INT()` here and below?
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableITCase.java
##########
@@ -61,21 +60,12 @@
private static final String AVRO_FORMAT = "avro";
private static final String CSV_FORMAT = "csv";
- @Parameterized.Parameter public boolean isLegacyConnector;
+ @Parameterized.Parameter public String format;
- @Parameterized.Parameter(1)
- public String format;
-
- @Parameterized.Parameters(name = "legacy = {0}, format = {1}")
+ @Parameterized.Parameters(name = "format = {0}")
public static Object[] parameters() {
return new Object[][] {
- // cover all 3 formats for new and old connector
- new Object[] {false, JSON_FORMAT},
- new Object[] {false, AVRO_FORMAT},
- new Object[] {false, CSV_FORMAT},
- new Object[] {true, JSON_FORMAT},
- new Object[] {true, AVRO_FORMAT},
- new Object[] {true, CSV_FORMAT}
+ new Object[] {JSON_FORMAT}, new Object[] {AVRO_FORMAT}, new
Object[] {CSV_FORMAT},
Review comment:
make it one dimensional
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/sinks/CsvAppendTableSinkFactory.java
##########
@@ -30,8 +31,12 @@
/**
* Factory base for creating configured instances of {@link CsvTableSink} in a
stream environment.
+ *
+ * @deprecated The legacy CSV connector has been replaced by {@link
FileSource}. It is kept only to
Review comment:
`FileSource`? Updates are required also at other locations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
