[ 
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322832#comment-15322832
 ] 

ASF GitHub Bot commented on FLINK-2985:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2078#discussion_r66476461
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/UnionITCase.scala
 ---
    @@ -69,6 +69,36 @@ class UnionITCase(
       }
     
       @Test
    +  def testUnionAllDifferentFieldNames(): Unit = {
    --- End diff --
    
    We are trying to reduce the number of ITCases in of the Table API and only 
add new ones if necessary to keep the build time low.
    
    I would change the existing tests to use different field names instead of 
adding new tests here. In addition the tests should try to select a field to 
check that the field names of the first input are forwarded.


> Allow different field names for unionAll() in Table API
> -------------------------------------------------------
>
>                 Key: FLINK-2985
>                 URL: https://issues.apache.org/jira/browse/FLINK-2985
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>            Reporter: Timo Walther
>            Priority: Minor
>
> The recently merged `unionAll` operator checks if the field names of the left 
> and right side are equal. Actually, this is not necessary. The union operator 
> in SQL checks only the types and uses the names of left side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to