[GitHub] [flink] akalash commented on a change in pull request #16628: [FLINK-23453][streaming] Created the buffer size calculator for the ability to automatically change the buffer size based on the throughput.

[GitBox]

akalash commented on a change in pull request #16628:
URL: https://github.com/apache/flink/pull/16628#discussion_r681527264



##########
File path: 
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -543,35 +543,34 @@
 
     /** The total time for which automated adjusted buffers should be fully 
consumed. */
     @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER_NETWORK)
-    public static final ConfigOption<Integer> 
AUTOMATIC_BUFFER_ADJUSTMENT_CONSUMPTION_TIME =
-            ConfigOptions.key(
-                            
"taskmanager.network.memory.automatic-buffer-adjustment.consumption-time")
-                    .intType()
-                    .defaultValue(1000)
+    public static final ConfigOption<Duration> BUFFER_DEBLOAT_TARGET =
+            
ConfigOptions.key("taskmanager.network.memory.buffer-debloat.target")
+                    .durationType()
+                    .defaultValue(Duration.ofSeconds(1))
                     .withDescription(
-                            "The total time for which automated adjusted 
buffers should be fully consumed. "
-                                    + "This means that the in-flight data 
between two subtask should be fully consumed for approximately this time.");
+                            "The target total time after which buffered 
in-flight data should be fully consumed. "
+                                    + "This configuration option will be used, 
in combination with the measured throughput, to adjust the amount of in-flight 
data.");
 
     @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER_NETWORK)
-    public static final ConfigOption<Boolean> 
AUTOMATIC_BUFFER_ADJUSTMENT_ENABLED =
-            
ConfigOptions.key("taskmanager.network.memory.automatic-buffer-adjustment.enabled")
+    public static final ConfigOption<Boolean> BUFFER_DEBLOAT_ENABLED =
+            
ConfigOptions.key("taskmanager.network.memory.buffer-debloat.enabled")
                     .booleanType()
-                    .defaultValue(false)
+                    .defaultValue(true)

Review comment:
       Yes, I believe so. Perhaps, I should add my properties to this file too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org