Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2069#discussion_r66606860
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSource.java
 ---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.kafka;
    +
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.table.sources.StreamTableSource;
    +import org.apache.flink.streaming.util.serialization.DeserializationSchema;
    +import 
org.apache.flink.streaming.util.serialization.JsonRowDeserializationSchema;
    +
    +import java.util.Properties;
    +
    +/**
    + * A version-agnostic Kafka JSON {@link StreamTableSource}.
    + *
    + * <p>The version-specific Kafka consumers need to extend this class and
    + * override {@link #getKafkaConsumer(String, Properties, 
DeserializationSchema)}}.
    + *
    + * <p>The field names are used to parse the JSON file and so are the types.
    + */
    +public abstract class KafkaJsonTableSource extends KafkaTableSource {
    --- End diff --
    
    Maybe. 😄 What do you have in mind? Users can also use the generic 
KafkaTableSource with their own row deserialization schema. Maybe that's more 
flexible. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to