curcur edited a comment on pull request #16653: URL: https://github.com/apache/flink/pull/16653#issuecomment-892379997
@akalash I've looked through the code again, I think we should probably also keep ``` timersFinishedFuture.get(); systemTimersFinishedFuture.get(); ``` in the task thread as well for the safety purposes. I mean we move this two lines of code into the actionExecutor and keep the same copy in its origin place. I think for normal task, actionExecutor is the same task thread, but there is also some cases (like sources) that use a different thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org