[ 
https://issues.apache.org/jira/browse/FLINK-23183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392843#comment-17392843
 ] 

Arvid Heise commented on FLINK-23183:
-------------------------------------

Merged into master as 900af3e43eb34f8899a4509a8f6c8e43d72f1cc8, into 1.13 as 
0ecb730e569de59b2e60a96405d8b138634b29b2, and into 1.12 as 
7e17c1d19da0e2330c508928cd3f1fc1e9494d03. Thank you very much!

> Lost ACKs for redelivered messages in RMQSource 
> ------------------------------------------------
>
>                 Key: FLINK-23183
>                 URL: https://issues.apache.org/jira/browse/FLINK-23183
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors/ RabbitMQ
>    Affects Versions: 1.13.1, 1.12.4
>            Reporter: Michał Ciesielczyk
>            Assignee: Michał Ciesielczyk
>            Priority: Major
>              Labels: pull-request-available
>
> As described in the FLINK-20244, the redelivered messages are not 
> acknowledged properly (only applicable when autoAck is disabled). When used 
> with a prefetch count in the consumer it may even lead to stop the source to 
> consume any more messages.
>  The solution (proposed in FLINK-20244) should resolve the issue. All 
> successfully consumed RMQ messages should be acknowledged, regardless of 
> whether the message is ignored or processed further in the pipeline. The 
> {{sessionIds.add(deliveryTag)}} 
> ([RMQSource.java#L423|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java#L423])
>  should be called before checking if the message has already been processed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to