[ https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324555#comment-15324555 ]
ASF GitHub Bot commented on FLINK-3937: --------------------------------------- Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2085#discussion_r66625805 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.client.cli; + +import org.apache.commons.cli.CommandLine; +import org.apache.commons.cli.Options; +import org.apache.flink.client.program.ClusterClient; +import org.apache.flink.configuration.Configuration; + + +/** + * Custom command-line interface to load hooks for the command-line interface. + */ +public interface CustomCommandLine<ClusterType extends ClusterClient> { + + /** + * Returns a unique identifier for this custom command-line. + * @return An unique identifier string + */ + String getIdentifier(); + + /** + * Adds custom options to the existing run options. + * @param baseOptions The existing options. + */ + void addRunOptions(Options baseOptions); + + /** + * Adds custom options to the existing general options. + * @param baseOptions The existing options. + */ + void addGeneralOptions(Options baseOptions); + + /** + * Retrieves a client for a running cluster + * @param commandLine The command-line parameters from the CliFrontend + * @param config The Flink config + * @return Client if a cluster could be retrieve, null otherwise --- End diff -- typo: retrieved > Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters > ------------------------------------------------------------------------------ > > Key: FLINK-3937 > URL: https://issues.apache.org/jira/browse/FLINK-3937 > Project: Flink > Issue Type: Improvement > Reporter: Sebastian Klemke > Assignee: Maximilian Michels > Priority: Trivial > Attachments: improve_flink_cli_yarn_integration.patch > > > Currently, flink cli can't figure out JobManager RPC location for > Flink-on-YARN clusters. Therefore, list, savepoint, cancel and stop > subcommands are hard to invoke if you only know the YARN application ID. As > an improvement, I suggest adding a -yid <yarnApplicationId> option to the > mentioned subcommands that can be used together with -m yarn-cluster. Flink > cli would then retrieve JobManager RPC location from YARN ResourceManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)