zlzhang0122 commented on a change in pull request #16637:
URL: https://github.com/apache/flink/pull/16637#discussion_r684122805
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -862,11 +862,19 @@ private void onTriggerSuccess() {
*/
private void onTriggerFailure(
CheckpointTriggerRequest onCompletionPromise, Throwable throwable)
{
- final CheckpointException checkpointException =
- getCheckpointException(
- CheckpointFailureReason.TRIGGER_CHECKPOINT_FAILURE,
throwable);
- onCompletionPromise.completeExceptionally(checkpointException);
- onTriggerFailure((PendingCheckpoint) null, checkpointException);
+ Throwable rootThrowable =
ExceptionUtils.stripCompletionException(throwable);
+ if (rootThrowable instanceof IOException) {
+ final CheckpointException checkpointException =
+
getCheckpointException(CheckpointFailureReason.IO_EXCEPTION, rootThrowable);
+ onCompletionPromise.completeExceptionally(checkpointException);
+ onTriggerFailure((PendingCheckpoint) null, throwable);
+ } else {
+ final CheckpointException checkpointException =
+ getCheckpointException(
+
CheckpointFailureReason.TRIGGER_CHECKPOINT_FAILURE, throwable);
+ onCompletionPromise.completeExceptionally(checkpointException);
+ onTriggerFailure((PendingCheckpoint) null, checkpointException);
Review comment:
You are right and I have also made a change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
