[
https://issues.apache.org/jira/browse/FLINK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327537#comment-15327537
]
ASF GitHub Bot commented on FLINK-3937:
---------------------------------------
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Thanks for the review! I've addressed almost all your comments and will
ping you once the PR get updated. Some more comments:
> (1) When listing the yarn-session.sh cli options, I could not see the
newly added argument
Fixed. The argument was not printed. The code now prints all available
options.
>Starting a YARN session works. Also, connecting with a second YARN session
works. However, if I'm stopping the session from the second session client, the
first one does not notice this.
It would be good if all connected clients receive the messages, instead of
the last one connected.
Yes, would be nice to have that feature but I think it is out of the scope
of this PR.
>Detached per job submission is not working (./bin/flink run -m
yarn-cluster -yd -yn 1 ./examples/batch/WordCount.jar)
You're running a WordCount with interactive job submission detached. That
doesn't work because the plan can't be extracted in interactive programs
(programs which use count/collect/print).
>While trying out your code, I noticed that the .yarn-properties file is
not properly deleted, even though my previous yarn session was shutting down
correctly:
I'll look into it. I know that this is also an issue in the current master.
I had the properties file lingering around many times. I think it is not
properly cleaned up in the ShutdownHook.
> Make flink cli list, savepoint, cancel and stop work on Flink-on-YARN clusters
> ------------------------------------------------------------------------------
>
> Key: FLINK-3937
> URL: https://issues.apache.org/jira/browse/FLINK-3937
> Project: Flink
> Issue Type: Improvement
> Reporter: Sebastian Klemke
> Assignee: Maximilian Michels
> Priority: Trivial
> Attachments: improve_flink_cli_yarn_integration.patch
>
>
> Currently, flink cli can't figure out JobManager RPC location for
> Flink-on-YARN clusters. Therefore, list, savepoint, cancel and stop
> subcommands are hard to invoke if you only know the YARN application ID. As
> an improvement, I suggest adding a -yid <yarnApplicationId> option to the
> mentioned subcommands that can be used together with -m yarn-cluster. Flink
> cli would then retrieve JobManager RPC location from YARN ResourceManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
