Airblader commented on a change in pull request #16776:
URL: https://github.com/apache/flink/pull/16776#discussion_r687675906
##########
File path: flink-python/pyflink/table/expression.py
##########
@@ -1393,6 +1414,47 @@ def json_exists(self, path: str, on_error:
JsonExistsOnError = None) -> 'Express
else:
return _ternary_op("jsonExists")(self, path,
on_error._to_j_json_exists_on_error())
+ def json_value(self,
+ path: str,
+ returning_type: DataType = None,
+ on_empty: JsonValueOnEmptyOrError = None,
+ default_on_empty: Any = None,
Review comment:
PEP8 is really weird with spaces. While `param: Type = value` is fine,
`param = value` gets rejected due to the spaces around `=`. Inconsistent
spacing sounded awful, so I explicitly typed it `Any` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
