[ 
https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330519#comment-15330519
 ] 

ASF GitHub Bot commented on FLINK-3650:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1856#discussion_r67049929
  
    --- Diff: 
flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
    @@ -23,9 +23,11 @@ import 
org.apache.flink.api.common.functions.{GroupCombineFunction, GroupReduceF
     import org.apache.flink.api.common.operators.{Keys, Order}
     import org.apache.flink.api.common.typeinfo.TypeInformation
     import org.apache.flink.api.java.aggregation.Aggregations
    -import org.apache.flink.api.java.functions.{FirstReducer, KeySelector}
    +import org.apache.flink.api.java.functions.{FirstReducer, KeySelector, 
SelectByMaxFunction, SelectByMinFunction}
    --- End diff --
    
    Remove `SelectByMaxFunction` and all other unnecessary imports.


> Add maxBy/minBy to Scala DataSet API
> ------------------------------------
>
>                 Key: FLINK-3650
>                 URL: https://issues.apache.org/jira/browse/FLINK-3650
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: ramkrishna.s.vasudevan
>
> The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}. 
> These methods are not supported by the Scala DataSet API. These methods 
> should be added in order to have a consistent API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to