[ 
https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330576#comment-15330576
 ] 

ASF GitHub Bot commented on FLINK-3650:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/1856
  
    Hi @ramkrish86, your approach is correct but the PR suffers from quite a 
few Scala issues. 
    Please fix the problems I pointed out and double check your code for 
compiler warnings, unused imports, semicolons in Scala code, etc.
    
    Thanks, Fabian


> Add maxBy/minBy to Scala DataSet API
> ------------------------------------
>
>                 Key: FLINK-3650
>                 URL: https://issues.apache.org/jira/browse/FLINK-3650
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: ramkrishna.s.vasudevan
>
> The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}. 
> These methods are not supported by the Scala DataSet API. These methods 
> should be added in order to have a consistent API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to