[GitHub] [flink] curcur commented on a change in pull request #16844: [FLINK-23724][network] Fix the network buffer leak when ResultPartition is released

[GitBox]

curcur commented on a change in pull request #16844:
URL: https://github.com/apache/flink/pull/16844#discussion_r690885852



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1182,7 +1186,10 @@ void 
cancelOrFailAndCancelInvokableInternal(ExecutionState targetState, Throwabl
                         Runnable canceler =
                                 new TaskCanceler(
                                         LOG,
-                                        this::closeNetworkResources,
+                                        () -> {
+                                            failAllResultPartitions();
+                                            closeAllInputGates();
+                                        },

Review comment:
       exaplain why changing resource release -> fail + release buff pool (but 
not buffers).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org