Arvid Heise created FLINK-23858: ----------------------------------- Summary: Clarify StreamRecord#timestamp. Key: FLINK-23858 URL: https://issues.apache.org/jira/browse/FLINK-23858 Project: Flink Issue Type: Technical Debt Components: Runtime / Network Reporter: Arvid Heise
The new Source apparently changed the way we specify records without timestamps. Previously, we used separate methods to create and maintain timestamp-less records. Now, we are shiftings towards using a special value (TimeStampAssigner#NO_TIMESTAMP). We first of all need to document that somewhere; at the very least in the JavaDoc of StreamRecord. We should also revise the consequences: - Do we want to encode it in the {{StreamElementSerializer}}? Currently, we use a flag to indicate no-timestamp on the old path but in the new path we now use 9 bytes to encode NO_TIMESTAMP. - We should check if all code-paths deal with `hasTimestamp() == true && getTimestamp() == TimeStampAssigner#NO_TIMESTAMP`, in particular with sinks. -- This message was sent by Atlassian Jira (v8.3.4#803005)