rkhachatryan commented on a change in pull request #16885:
URL: https://github.com/apache/flink/pull/16885#discussion_r692329478
##########
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/output/BoundedStreamTask.java
##########
@@ -116,7 +116,7 @@ protected void processInput(MailboxDefaultAction.Controller
controller) throws E
protected void cancelTask() {}
@Override
- protected void cleanup() throws Exception {
+ protected void cleanUpInternal() throws Exception {
Review comment:
I only see two methods now: `cleanUp` and `cleanUpInternal`.
They are meant to implement "template method" pattern with a usual naming in
Flink (`public xxx()` calling `protected xxxInternal()`).
As for naming differently, the difference is not semantic - they both do
some cleanup; `cleanUpInternal` just allows subclasses to hook into it.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
