[ 
https://issues.apache.org/jira/browse/FLINK-23889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402962#comment-17402962
 ] 

Zhu Zhu commented on FLINK-23889:
---------------------------------

Looks to me that "Clearing resource requirements ..." is printed each time the 
resource manager receives an empty resource declaration.
I think if the previous resource requirements in SlotManager is already empty, 
there is no need to print this log.
In declarative slot allocation, I think it's acceptable that the JM can send an 
empty resource declaration to RM multiple times.

> Unnecessary logging from FineGrainedSlotManager
> -----------------------------------------------
>
>                 Key: FLINK-23889
>                 URL: https://issues.apache.org/jira/browse/FLINK-23889
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.14.0
>            Reporter: Chesnay Schepler
>            Assignee: Yangze Guo
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> This is what the slot manager logs when creating a standalone cluster, 
> without running any job:
> {code}
> 2021-08-20 09:21:49,586 INFO  FineGrainedSlotManager [] - Registering task 
> executor [::1]:45785-0effb8 under 71b35bc7267c2a5aa290fc5bc3789d56 at the 
> slot manager.
> 2021-08-20 09:21:49,593 INFO  FineGrainedSlotManager [] - Scheduling the 
> resource requirement check.
> 2021-08-20 09:21:49,660 INFO  FineGrainedSlotManager [] - Matching resource 
> requirements against available resources.
> 2021-08-20 09:22:48,465 INFO  FineGrainedSlotManager [] - Release TaskManager 
> 71b35bc7267c2a5aa290fc5bc3789d56 because it exceeded the idle timeout.
> {code}
> These are additional messages being logged when submitting a job:
> {code}
> 2021-08-20 09:26:57,943 INFO  FineGrainedSlotManager [] - Allocating task 
> managers for the resource requirements.
> 2021-08-20 09:26:58,803 INFO  FineGrainedSlotManager [] - Clearing resource 
> requirements of job bdb66574e9629e9090aa173e408f9625
> {code}
> {{Scheduling the resource requirement check.}} is unnecessary information 
> that provides no benefits. It is also logged repeatedly for some reason.
> {{Matching resource requirements against available resources.}} should only 
> be logged if there are any requirements to actually match against.
> {{Release TaskManager XXX because it exceeded the idle timeout}} is not 
> applicable in standalone mode; it is also logged repeatedly.
> {{Allocating task managers for the resource requirements.}} is not applicable 
> to standalone mode.
> {{Clearing resource requirements of job XXX}} is logged twice for each job.
> This also happens for the DeclarativeSlotManager.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to