nicolasraga1 commented on a change in pull request #16946:
URL: https://github.com/apache/flink/pull/16946#discussion_r696202246
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerSharedServices.java
##########
@@ -47,7 +48,9 @@
*/
public class JobManagerSharedServices {
- private final ScheduledExecutorService scheduledExecutorService;
+ private final ScheduledExecutorService futureExecutor;
+
+ private final ScheduledExecutorService ioExecutor;
Review comment:
`ScheduledExecutorService` can also be terminated since it extends
`ExecutorService`. However, we don't seem to use the scheduling functionality
added on top. I'll make it an `ExecutorService` such that we can still shut it
down and terminate it (as opposed to `Executor`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
