KarmaGYZ commented on a change in pull request #16959: URL: https://github.com/apache/flink/pull/16959#discussion_r697104755
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java ########## @@ -117,7 +117,7 @@ public void increaseResourceRequirementsBy(ResourceCounter increment) { @Override public void decreaseResourceRequirementsBy(ResourceCounter decrement) { - if (decrement.isEmpty()) { + if (decrement.isEmpty() || totalResourceRequirements.isEmpty()) { Review comment: Thanks @zhuzhurk for the investigation. I would only keep the second commit 654b7c476 in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org