[ 
https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336173#comment-15336173
 ] 

ASF GitHub Bot commented on FLINK-3951:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2112#discussion_r67515502
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
    @@ -99,8 +100,11 @@ public void notifyOfAddedMetric(Metric metric, String 
metricName, AbstractMetric
                        jmxMetric = new JmxGauge((Gauge<?>) metric);
                } else if (metric instanceof Counter) {
                        jmxMetric = new JmxCounter((Counter) metric);
    +           } else if (metric instanceof Histogram) {
    +                   jmxMetric = new JmxHistogram((Histogram) metric);
                } else {
    -                   LOG.error("Unknown metric type: " + 
metric.getClass().getName());
    +                   LOG.error("Cannot add unknown metric type: {}. This 
indicates that the metric type " +
    --- End diff --
    
    should use the log field in AbstractReporter


> Add Histogram Metric Type
> -------------------------
>
>                 Key: FLINK-3951
>                 URL: https://issues.apache.org/jira/browse/FLINK-3951
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Stephan Ewen
>            Assignee: Till Rohrmann
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to