[ 
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338707#comment-15338707
 ] 

ASF GitHub Bot commented on FLINK-3034:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r67622177
  
    --- Diff: 
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
 ---
    @@ -0,0 +1,190 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis.common.container;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import redis.clients.jedis.JedisCluster;
    +
    +import java.io.Closeable;
    +import java.io.IOException;
    +
    +/**
    + * Redis command container if we want to connect to a Redis cluster.
    + */
    +public class RedisClusterContainer implements RedisCommandsContainer, 
Closeable {
    +
    +   private static final long serialVersionUID = 1L;
    +
    +   private static final Logger LOG = 
LoggerFactory.getLogger(RedisClusterContainer.class);
    +
    +   private JedisCluster jedisCluster;
    +
    +   /**
    +    * Initialize Redis command container for Redis cluster.
    +    *
    +    * @param jedisCluster JedisCluster instance
    +    */
    +   public RedisClusterContainer(JedisCluster jedisCluster) {
    +           this.jedisCluster = jedisCluster;
    +   }
    +
    +   /**
    +    * Sets field in the hash stored at key to value.
    +    * If key does not exist, a new key holding a hash is created.
    +    * If field already exists in the hash, it is overwritten.
    +    *
    +    * @param hashName   Hash name
    +    * @param key Hash field name
    +    * @param value Hash value
    +    */
    +   @Override
    +   public void hset(final String hashName, final String key, final String 
value) {
    +           try {
    +                   jedisCluster.hset(hashName, key, value);
    +           } catch (Exception e) {
    +                   if (LOG.isErrorEnabled()) {
    +                           LOG.error("Cannot send Redis message with 
command HSET to hash {} error message {}",
    +                                   hashName, key, e.getMessage());
    +                   }
    +           }
    +   }
    +
    +   /**
    +    * Insert all the specified values at the tail of the list stored at 
key.
    --- End diff --
    
    Why "all ... values" -- it is a single string. Or do I miss something?


> Redis SInk Connector
> --------------------
>
>                 Key: FLINK-3034
>                 URL: https://issues.apache.org/jira/browse/FLINK-3034
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>            Reporter: Matthias J. Sax
>            Assignee: Subhankar Biswas
>            Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to