HuangXingBo commented on a change in pull request #17090:
URL: https://github.com/apache/flink/pull/17090#discussion_r699873020
##########
File path: flink-python/pyflink/fn_execution/coder_impl_fast.pyx
##########
@@ -19,6 +19,8 @@
# cython: infer_types = True
# cython: profile=True
# cython: boundscheck=False, wraparound=False, initializedcheck=False,
cdivision=True
+from types import GeneratorType
+from typing import Iterable
Review comment:
change to `from collections import Iterable, Generator`?
##########
File path: flink-python/pyflink/fn_execution/coder_impl_fast.pyx
##########
@@ -19,6 +19,8 @@
# cython: infer_types = True
# cython: profile=True
# cython: boundscheck=False, wraparound=False, initializedcheck=False,
cdivision=True
+from types import GeneratorType
Review comment:
put these two imports together with other python imports
##########
File path: flink-python/pyflink/fn_execution/beam/beam_coder_impl_slow.py
##########
@@ -18,9 +18,11 @@
import datetime
import decimal
+from types import GeneratorType
Review comment:
change to `from collections import Iterable, Generator` and put this
import after the `import struct`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
