SteNicholas commented on a change in pull request #17105:
URL: https://github.com/apache/flink/pull/17105#discussion_r701624586



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -347,6 +375,7 @@ private DataInputStatus emitNextNotReading(DataOutput<OUT> 
output) throws Except
         switch (operatingMode) {
             case OUTPUT_NOT_INITIALIZED:
                 currentMainOutput = eventTimeLogic.createMainOutput(output);
+                latencyMarerEmitter.setMainOutput(output);

Review comment:
       @pnowojski , I prefer to construct the `LatencyMarkerEmitter` in the 
`open` method, which follows the pattern of `eventTimeLogic` and set the 
`DataOutput` in the `emitNext` method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to