stevenzwu commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r702108667
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceEnumeratorStateSerializer.java
##########
@@ -54,12 +44,9 @@ public int getVersion() {
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
DataOutputStream out = new DataOutputStream(baos)) {
out.writeInt(enumState.getCurrentSourceIndex());
- SimpleVersionedSerializer<Object> serializer =
- serializerOf(enumState.getCurrentSourceIndex());
- out.writeInt(serializer.getVersion());
- byte[] enumStateBytes =
serializer.serialize(enumState.getWrappedState());
- out.writeInt(enumStateBytes.length);
- out.write(enumStateBytes);
+ out.writeInt(enumState.wrappedStateSerializerVersion());
+ out.writeInt(enumState.getWrappedState().length);
Review comment:
@tweise I have thought about adding the optimization (of limiting the
number of splits) for streaming read in the future. for bounded job, we can't.
on the other hand, bounded job may not need to have checkpoint enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
