twalthr commented on a change in pull request #17242:
URL: https://github.com/apache/flink/pull/17242#discussion_r707090588
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java
##########
@@ -629,7 +629,7 @@
logical(LogicalTypeFamily.CHARACTER_STRING),
logical(LogicalTypeFamily.CHARACTER_STRING),
logical(LogicalTypeRoot.INTEGER))))
-
.outputTypeStrategy(nullableIfArgs(explicit(DataTypes.STRING())))
+
.outputTypeStrategy(forceNullable(explicit(DataTypes.STRING())))
Review comment:
`forceNullable` is useful for a more "dynamic argument", but since this
is static. you can simply express this as
`explicit(DataTypes.STRING().nullable())`. Nullable is actually the default,
but this would make it more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
