zjuwangg commented on a change in pull request #17272:
URL: https://github.com/apache/flink/pull/17272#discussion_r707869440
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/JoinTest.scala
##########
@@ -32,6 +32,21 @@ class JoinTest extends TableTestBase {
util.addTableSource[(Int, Long, String)]("t", 'a, 'b, 'c)
util.addTableSource[(Long, String, Int)]("s", 'x, 'y, 'z)
+ @Test
+ def testDependentConditionderivationInnerJoin: Unit = {
Review comment:
```suggestion
def testDependentConditionDerivationInnerJoin: Unit = {
```
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/JoinTest.scala
##########
@@ -32,6 +32,21 @@ class JoinTest extends TableTestBase {
util.addTableSource[(Int, Long, String)]("t", 'a, 'b, 'c)
util.addTableSource[(Long, String, Int)]("s", 'x, 'y, 'z)
+ @Test
+ def testDependentConditionderivationInnerJoin: Unit = {
+ util.verifyExecPlan("SELECT a1, b1 FROM A JOIN B ON (a1 = 1 AND b1 = 1) OR
(a2 = 2 AND b2 = 2)")
+ }
+
+ @Test
+ def testDependentConditionderivationInnerJoinWithTrue: Unit = {
Review comment:
ditto
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/table/JoinTest.scala
##########
@@ -31,6 +31,48 @@ import java.sql.Timestamp
*/
class JoinTest extends TableTestBase {
+ @Test
+ def testDependentConditionderivationInnerJoin: Unit = {
Review comment:
Ditto and all new added following method name should change.
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/JoinTest.scala
##########
@@ -32,6 +32,21 @@ class JoinTest extends TableTestBase {
util.addTableSource[(Int, Long, String)]("t", 'a, 'b, 'c)
util.addTableSource[(Long, String, Int)]("s", 'x, 'y, 'z)
+ @Test
+ def testDependentConditionderivationInnerJoin: Unit = {
+ util.verifyExecPlan("SELECT a1, b1 FROM A JOIN B ON (a1 = 1 AND b1 = 1) OR
(a2 = 2 AND b2 = 2)")
+ }
+
+ @Test
+ def testDependentConditionderivationInnerJoinWithTrue: Unit = {
+ util.verifyExecPlan("SELECT a1, b1 FROM A JOIN B ON (a1 = 1 AND b1 = 1) OR
(a2 = 2 AND true)")
+ }
+
+ @Test
+ def testDependentConditionderivationInnerJoinWithNull: Unit = {
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
