[ 
https://issues.apache.org/jira/browse/FLINK-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344254#comment-15344254
 ] 

ASF GitHub Bot commented on FLINK-3919:
---------------------------------------

Github user chiwanpark commented on the issue:

    https://github.com/apache/flink/pull/1996
  
    Looks good to me, +1. I'll merge this in few hours.
    
    But I think we should change the type of row index to `Long` in near 
future. I think we can deal with the incompatibility problem with local 
matrices by assuming that the number of rows is less than `Int.MaxValue` and 
converting row index type from `Long` to `Int` in collecting time. I'll submit 
an issue related to this to JIRA after merge this.


> Distributed Linear Algebra: row-based matrix
> --------------------------------------------
>
>                 Key: FLINK-3919
>                 URL: https://issues.apache.org/jira/browse/FLINK-3919
>             Project: Flink
>          Issue Type: New Feature
>          Components: Machine Learning Library
>            Reporter: Simone Robutti
>            Assignee: Simone Robutti
>
> Distributed matrix implementation as a DataSet of IndexedRow and related 
> operations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to