Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68053983
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -66,23 +68,44 @@
// Scope Variables
//
------------------------------------------------------------------------
+ public static final String SCOPE_ACTOR_HOST = asVariable("host");
+
+ // ----- Job Manager ----
+
+ /** The default scope format of the JobManager component: {@code
"<host>.jobmanager"} */
+ public static final String DEFAULT_SCOPE_JOBMANAGER_COMPONENT =
+ concat(SCOPE_ACTOR_HOST, "jobmanager");
+
+ /** The default scope format of JobManager metrics: {@code
"<host>.jobmanager"} */
+ public static final String DEFAULT_SCOPE_JOBMANAGER_GROUP =
DEFAULT_SCOPE_JOBMANAGER_COMPONENT;
+
// ----- Task Manager ----
- public static final String SCOPE_TASKMANAGER_HOST = asVariable("host");
public static final String SCOPE_TASKMANAGER_ID = asVariable("tm_id");
/** The default scope format of the TaskManager component: {@code
"<host>.taskmanager.<tm_id>"} */
public static final String DEFAULT_SCOPE_TASKMANAGER_COMPONENT =
- concat(SCOPE_TASKMANAGER_HOST, "taskmanager",
SCOPE_TASKMANAGER_ID);
+ concat(SCOPE_ACTOR_HOST, "taskmanager",
SCOPE_TASKMANAGER_ID);
/** The default scope format of TaskManager metrics: {@code
"<host>.taskmanager.<tm_id>"} */
public static final String DEFAULT_SCOPE_TASKMANAGER_GROUP =
DEFAULT_SCOPE_TASKMANAGER_COMPONENT;
- // ----- Job on Task Manager ----
+ // ----- Job -----
public static final String SCOPE_JOB_ID = asVariable("job_id");
public static final String SCOPE_JOB_NAME = asVariable("job_name");
+ // ----- Job on Job Manager ----
+
+ /** The default scope format for the job component: {@code
"<job_name>"} */
+ public static final String DEFAULT_SCOPE_JOBMANAGER_JOB_COMPONENT =
SCOPE_JOB_NAME;
+
+ /** The default scope format for all job metrics: {@code
"<host>.taskmanager.<tm_id>.<job_name>"} */
--- End diff --
Shouldn't it be `<host>.jobmanager.<job_name>`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
