Jiayi-Liao commented on pull request #17151:
URL: https://github.com/apache/flink/pull/17151#issuecomment-919960672


   > > I think in the end there is no harm doing so, but a the very least the 
javadoc must be updated. I would even suggest renaming initializeBaseLocations 
to initializeBaseLocationsForCheckpoints.
   > 
   > I think @dawidwys 's suggestion is right, we should change the javadoc 
description. Since this class is not annoated as "Public" and might not be 
extended in user classes, it's fine to rename this method (the renaming commit 
could be a separate one).
   
   @dawidwys @Myasuka  You're right. Will fix this soon...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to