Myasuka commented on a change in pull request #17203:
URL: https://github.com/apache/flink/pull/17203#discussion_r709711663



##########
File path: 
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -190,6 +194,19 @@
 
     private final ExecutorService asyncOperationsThreadPool;
 
+    /**
+     * Identifies this backend. On restore, when snapshots of multiple 
backends are present
+     * (downscaling case) this allows to differentiate between state mappings 
of different backends.

Review comment:
       Actually, upscaling case could also cause this case (such as change 
parallelism 2 to 3).

##########
File path: 
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -190,6 +194,19 @@
 
     private final ExecutorService asyncOperationsThreadPool;
 
+    /**
+     * Identifies this backend. On restore, when snapshots of multiple 
backends are present
+     * (downscaling case) this allows to differentiate between state mappings 
of different backends.

Review comment:
       Actually, upscaling case could also cause this case (such as change 
parallelism from 2 to 3).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to