[
https://issues.apache.org/jira/browse/FLINK-24207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420492#comment-17420492
]
Arvid Heise edited comment on FLINK-24207 at 9/27/21, 6:06 AM:
---------------------------------------------------------------
I'm a bit torn on this one. It sounds like a reasonable idea. However, we are
in the process of phasing out the old {{SinkFunction}} and I wouldn't want to
invest too much into the respective implementations.
To add, the only known implementation of \{{TwoPhaseCommitSinkFunction}} is
{{KafkaProducer}} and that's now deprecated.
Any contribution is welcome though.
was (Author: arvid):
I'm a bit torn on this one. It sounds like a reasonable idea. However, we are
in the process of phasing out the old {{SinkFunction}} and I wouldn't want to
invest too much into the respective implementations.
> Add support of KeyedState in TwoPhaseCommitSinkFunction
> -------------------------------------------------------
>
> Key: FLINK-24207
> URL: https://issues.apache.org/jira/browse/FLINK-24207
> Project: Flink
> Issue Type: New Feature
> Components: API / DataStream
> Affects Versions: 1.12.2, 1.13.1
> Reporter: zlzhang0122
> Priority: Major
> Fix For: 1.14.1
>
>
> Now, the implementation of TwoPhaseCommitSinkFunction is based on operator
> state, but operator state will do a deep copy when taking checkpoint, so
> large operator state may produce a OOM error. Add support of KeyedState in
> TwoPhaseCommitSinkFunction maybe a good choice to avoid the OOM error and
> give users more convenience.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
