sjwiesman commented on pull request #274: URL: https://github.com/apache/flink-statefun/pull/274#issuecomment-940558983
The general implementation looks good. My only comment is on the API. It feels strange to me that we have `FunctionTypeScopedMetrics` and `RouterMetrics` as two separate interfaces. Could we unify them into one interface? I also really like the cleanup of `LocalFunctionGroup`, that whole part of the codebase is much easier to follow :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org