Github user mjsax commented on the issue:
https://github.com/apache/flink/pull/1813
My two cents:
1) seems to got sorted out (thx @tzulitai for the input!)
2) I personally do not care too much about the name conflict. Reusing the
same class for sink and source sounds reasonable. Maybe `FlinkRedisConfig` as
name?
3) Agreed. `PUBSUB` as datatpye is fine IMHO (so we can use same type for
source and sink, which makes it clear if PUB or SUB is used)
4 + 5 ) Your suggestions sound good to me. Please update PR so we can get
better lock and feel for it :)
@tzulitai @subhankarb Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
