Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68711841
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@ -155,55 +199,79 @@ public GetRecordsResult getRecords(String
shardIterator, int maxRecordsToGet) {
* @param startingSeqNum the sequence number that the iterator will
start from
* @return the shard iterator
*/
+ @Override
public String getShardIterator(KinesisStreamShard shard, String
shardIteratorType, String startingSeqNum) {
- return kinesisClient.getShardIterator(shard.getStreamName(),
shard.getShardId(), shardIteratorType, startingSeqNum).getShardIterator();
+ return kinesisClient.getShardIterator(shard.getStreamName(),
shard.getShard().getShardId(), shardIteratorType,
startingSeqNum).getShardIterator();
--- End diff --
@rmetzger This method doesn't do the
`ProvisionedThroughputExceededException` check / retries like the
`getRecords()` method. Perhaps we should be checking that + fail hard after
retrying too, as it also has a 5 requests per second limit? Reasoning is the
same as my reply to your comment on the `getRecords()` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
