[ 
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352678#comment-15352678
 ] 

ASF GitHub Bot commented on FLINK-1550:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68726906
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -149,6 +154,16 @@ class JobManager(
     
       var leaderSessionID: Option[UUID] = None
     
    +  protected val jobManagerMetricGroup : Option[JobManagerMetricGroup] = 
metricsRegistry match {
    +    case Some(registry) =>
    +      val host = 
flinkConfiguration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, null)
    +      Option(new JobManagerMetricGroup(
    +        registry, 
NetUtils.ipAddressToUrlString(InetAddress.getByName(host))))
    +    case None =>
    +      log.error("Could not instantiate JobManager metrics.")
    --- End diff --
    
    Is this an error or more of a warning? I mean the system would still run, 
wouldn't it?


> Show JVM Metrics for JobManager
> -------------------------------
>
>                 Key: FLINK-1550
>                 URL: https://issues.apache.org/jira/browse/FLINK-1550
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to