Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68731503
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1082,6 +1110,13 @@ class JobManager(
log.info(s"Using restart strategy $restartStrategy for $jobId.")
+ val jobMetrics = jobManagerMetricGroup match {
+ case Some(group) =>
+ group.addJob(jobGraph.getJobID, jobGraph.getName)
--- End diff --
Do you think returning null is a good pattern in the first place? I'd
rather return a jobGroup that is neither stored in the jobManagerMetricGroup
nor registers any metrics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
