nicoweidner commented on a change in pull request #17474: URL: https://github.com/apache/flink/pull/17474#discussion_r733629841
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherCachedOperationsHandler.java ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.dispatcher; + +import org.apache.flink.runtime.messages.Acknowledge; +import org.apache.flink.runtime.rest.handler.async.CompletedOperationCache; +import org.apache.flink.runtime.rest.handler.async.OperationResult; +import org.apache.flink.runtime.rest.handler.async.OperationResultStatus; +import org.apache.flink.runtime.rest.handler.async.UnknownOperationKeyException; +import org.apache.flink.runtime.rest.handler.job.AsynchronousJobOperationKey; + +import java.util.Optional; +import java.util.concurrent.CompletableFuture; +import java.util.function.Function; + +/** + * A handler for async operations triggered by the {@link Dispatcher} whose trigger parameters and + * results are cached. + */ +public class DispatcherCachedOperationsHandler { + + private final CompletedOperationCache<AsynchronousJobOperationKey, String> + savepointTriggerCache; + + private final Function<TriggerSavepointParameters, CompletableFuture<String>> + triggerSavepointFunction; + + private final Function<TriggerSavepointParameters, CompletableFuture<String>> + stopWithSavepointFunction; + + DispatcherCachedOperationsHandler( + Function<TriggerSavepointParameters, CompletableFuture<String>> + triggerSavepointFunction, + Function<TriggerSavepointParameters, CompletableFuture<String>> + stopWithSavepointFunction) { + this(triggerSavepointFunction, stopWithSavepointFunction, new CompletedOperationCache<>()); + } + + DispatcherCachedOperationsHandler( + Function<TriggerSavepointParameters, CompletableFuture<String>> + triggerSavepointFunction, + Function<TriggerSavepointParameters, CompletableFuture<String>> + stopWithSavepointFunction, + CompletedOperationCache<AsynchronousJobOperationKey, String> savepointTriggerCache) { + this.triggerSavepointFunction = triggerSavepointFunction; + this.stopWithSavepointFunction = stopWithSavepointFunction; + this.savepointTriggerCache = savepointTriggerCache; + } + + public CompletableFuture<Acknowledge> triggerSavepoint( + AsynchronousJobOperationKey operationKey, TriggerSavepointParameters parameters) { + return registerOperationIdempotently(operationKey, triggerSavepointFunction, parameters); + } + + public CompletableFuture<Acknowledge> stopWithSavepoint( + AsynchronousJobOperationKey operationKey, TriggerSavepointParameters parameters) { + return registerOperationIdempotently(operationKey, stopWithSavepointFunction, parameters); + } + + public CompletableFuture<OperationResult<String>> getSavepointStatus( + AsynchronousJobOperationKey operationKey) { + return savepointTriggerCache + .get(operationKey) + .map(CompletableFuture::completedFuture) + .orElse( + CompletableFuture.failedFuture( + new UnknownOperationKeyException(operationKey))); + } + + public CompletableFuture<Void> shutDownCache() { + return savepointTriggerCache.closeAsync(); + } + + private <P> CompletableFuture<Acknowledge> registerOperationIdempotently( + AsynchronousJobOperationKey operationKey, + Function<P, CompletableFuture<String>> operation, + P parameters) { + Optional<OperationResult<String>> resultOptional = savepointTriggerCache.get(operationKey); + if (resultOptional.isPresent()) { + return convertToFuture(resultOptional.get()); + } + + try { + savepointTriggerCache.registerOngoingOperation( + operationKey, operation.apply(parameters)); + } catch (IllegalStateException e) { + return CompletableFuture.failedFuture(e); Review comment: I guess it just changes how the exception can be handled upstream (wrapped in a failed future or directly as an exception). Would you suggest to not catch it at all and let the top-level REST handler take care of it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
