JingGe commented on pull request #17501:
URL: https://github.com/apache/flink/pull/17501#issuecomment-948663153


   > Thanks for the nice discussion! I think I now better understand the 
contribution.
   > 
   > Can you rename the class `AvroParquetRecordFormat` to `ParquetAvro...`? 
The codebase already has a `ParquetAvroWriters` class and it would be nice to 
keep it consistent.
   
   I named it after the naming convention from apache parquet lib e.g. 
`AvroParquetReader`. It sound nature for "reading avro from parquet". I would 
suggest we change ParquetAvroWriters to AvroParquetWriters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to