xuyangzhong opened a new pull request #17546:
URL: https://github.com/apache/flink/pull/17546


   ## What is the purpose of the change
   This pull request mainly helps give users clearer exception messages when 
the divisor is zero. Before, 1.0e0 / 0.0e0 will be computed to infinity and 
when converting it to decimal, an exception "Infinite or NaN" is thrown . Now 
we follow the SQL Standard: throw "Division by zero".
   
   ## Brief change log
   - add validate function in ExpressionReducer.
   - add a rule in ExpressionTestBase to fire the expression reducer.
   - change some existing test cases.
   - add some test cases to verify this change.
   
   ## Verifying this change
   - Some test cases have been added to verify this change.
   
   ## Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with 
@Public(Evolving): no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   - The S3 file system connector: no
   ## Documentation
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to