gaoyunhaii commented on pull request #5: URL: https://github.com/apache/flink-ml/pull/5#issuecomment-950339981
Very thanks @guoweiM for the review! I updated the PR to fix the inline comments. Regarding the style of the api: during the discussion we indeed have another possible option: use a kind of mini-batch style api to model the offline training and online training in a unify style. However, we found that even in this way users could not write one program to fit both offline and online easily. This comes from the fact that the offline and corresponding online algorithms usually not the same. Thus we tend to provide the different interface for the offline and online scenarios. Although we provide the dedicated API for the different types of the scenarios, they are still build on the same model of progress tracking, and shares almost all the implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
