Airblader commented on a change in pull request #17549: URL: https://github.com/apache/flink/pull/17549#discussion_r735824538
########## File path: docs/data/sql_functions.yml ########## @@ -766,6 +766,27 @@ json: ) ) ``` + - sql: JSON_OBJECTAGG([KEY] key VALUE value [ { NULL | ABSENT } ON NULL ]) + table: jsonObjectAgg(JsonOnNull, keyExpression, valueExpression) + description: | + Builds a JSON object string by aggregating over key-value expressions. Review comment: > I find the name not very intuitive for what it is doing. It is actually a "union" of key-value pairs but uses the term "agg". I think of it as a function that aggregates key-values into a single JSON object, which makes sense to me. :-) > can we add an example with JSON? I've changed the example entirely to something that I think makes sense without having to "set it up". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org